Fix MA0042 false positive when non-generic method has a same-named generic overload with awaitable return type#1102
Merged
Conversation
…le same-named overload Agent-Logs-Url: https://github.com/meziantou/Meziantou.Analyzer/sessions/771fa8ce-1473-48ab-acdf-f27908b008c1 Co-authored-by: meziantou <509220+meziantou@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix false positive of MA0042 in version 3.0.41
Fix MA0042 false positive when non-generic method has a same-named generic overload with awaitable return type
Apr 24, 2026
meziantou
approved these changes
Apr 24, 2026
This was referenced Apr 24, 2026
This was referenced May 9, 2026
Closed
Closed
Closed
Merged
Open
This was referenced May 16, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MA0042 incorrectly reports a diagnostic when a non-generic method (e.g., TUnit's
Assert.That(string?)) coexists with a same-named generic overload (e.g.,Assert.That<T>(T)) that returns an awaitable type. The suggested fix (await Assert.That(x)) fails to compile because C# overload resolution always prefers non-generic methods — the call still resolves to the non-awaitable non-generic overload.Changes
DoNotUseBlockingCallInAsyncContextAnalyzer.cs: InFindPotentialAsyncEquivalent, skip generic candidates when performing a same-name search (methodName == targetMethod.Name) and the original method is non-generic. Since the compiler will always prefer the non-generic overload at the call site, the generic awaitable variant can never actually be selected by applyingawait.DoNotUseBlockingCallInAsyncContextAnalyzer_AsyncContextTests.cs: Regression test covering the pattern below.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
st8vsblobprodcus339.vsblob.vsassets.io/usr/share/dotnet/dotnet dotnet restore --no-dependencies /home/REDACTED/work/Meziantou.Analyzer/Meziantou.Analyzer/Meziantou.Analyzer.slnx --packages /tmp/codeql-scratch-8ad8dc5536a632e8/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-8ad8dc5536a632e8/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-8ad8dc5536a632e8/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true(dns block)/usr/share/dotnet/dotnet dotnet restore --no-dependencies /home/REDACTED/work/Meziantou.Analyzer/Meziantou.Analyzer/tests/Meziantou.Analyzer.Test/Meziantou.Analyzer.Test.csproj --packages /tmp/codeql-scratch-8ad8dc5536a632e8/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-8ad8dc5536a632e8/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-8ad8dc5536a632e8/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true(dns block)If you need me to access, download, or install something from one of these locations, you can either: